Rename PR remote option to --pr-remote#106
Merged
Mariatta merged 1 commit intoJun 4, 2017
python:masterpython/core-workflow:masterfrom
ncoghlan:rename-pr-remote-optionncoghlan/core-workflow:rename-pr-remote-optionCopy head branch name to clipboard
Merged
Rename PR remote option to --pr-remote#106Mariatta merged 1 commit intopython:masterpython/core-workflow:masterfrom ncoghlan:rename-pr-remote-optionncoghlan/core-workflow:rename-pr-remote-optionCopy head branch name to clipboard
Mariatta merged 1 commit into
python:masterpython/core-workflow:masterfrom
ncoghlan:rename-pr-remote-optionncoghlan/core-workflow:rename-pr-remote-optionCopy head branch name to clipboard
Conversation
The new --push/--no-push option conflicts with the old name of the option for setting the PR remote. This updates the latter option to the more explicit `--pr-remote`.
Contributor
Author
|
Tested by generating python/cpython#1921 and it seems to mostly work. However, it would be good to remember the PR remote name in the |
Mariatta
approved these changes
Jun 4, 2017
Member
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new --push/--no-push option conflicts with the old name
of the option for setting the PR remote.
This updates the latter option to the more explicit
--pr-remote.