Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

GitHub Action Ubuntu job doesn't check if generated files are up to date #380

Copy link
Copy link
@vstinner

Description

@vstinner
Issue body actions

Previously, Travis CI was mandatory on Python PRs. Travis CI was made optional, and instead GHA Ubuntu was made required.

The problem is that only Travis CI checked if generated files are up to date:

  - eval "$(pyenv init -)"
  - pyenv global 3.8
  - PYTHON_FOR_REGEN=python3.8 make -j4 regen-all
  - changes=`git status --porcelain`
  - |
      # Check for changes in regenerated files
      if ! test -z "$changes"
      then
        echo "Generated files not up to date"
        echo "$changes"
        exit 1
      fi
  - make -j4
  - make pythoninfo

These commands should be copied and adapted in .github/workflows/build.yml.

Is there a volunteer to do that?

cc @FFY00 @ammaraskar

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.