You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A. The instructions are for *nix/bash and will not work as given on Windows. Has cherry-picker been successfully run on Windows?
Comments on individual setup lines:
1,2: okay.
Replace the non-existent 'python3' with 'py -3.6'. (Unlike 'python3', this is guaranteed to run 3.6 or fail.) I gather that this creates a venv directory called 'venv', which I presume is git-ignored.
Replace 'source ...' with 'venv\Scripts\activate.bat'. The venv doc says that 'activate' is not necessary but add the 'binary' directory (venv/bin or venv/Scripts) to the the path. It appears to also change the shell prompt.
This does not have the (venv) prompt. Is it just missing? Or is there a missing deactivate command? In other words, is line 7 supposed to be executed in or out of the venv. If the latter, should it not be moved up before line 3?
C. Am I correct in thinking that the setup lines (other than activate) are 1-time only, or do any have to be repeated to do further cherry-picks?
D. How does one cherry-pick multiple PRs for an issue into one backport PR? This should usually be much easier than doing multiple backports, as the backport for each dependent PR needs to wait for the previous one to be tested and merged.
Reading the readme.rst displayed on https://github.com/python/core-workflow/tree/master/cherry_picker, I have questions and comments that I hope lead to improved instructions. I am on Windows and have never used venv.
A. The instructions are for *nix/bash and will not work as given on Windows. Has cherry-picker been successfully run on Windows?
Comments on individual setup lines:
1,2: okay.
Replace the non-existent 'python3' with 'py -3.6'. (Unlike 'python3', this is guaranteed to run 3.6 or fail.) I gather that this creates a venv directory called 'venv', which I presume is git-ignored.
Replace 'source ...' with 'venv\Scripts\activate.bat'. The venv doc says that 'activate' is not necessary but add the 'binary' directory (venv/bin or venv/Scripts) to the the path. It appears to also change the shell prompt.
This does not have the (venv) prompt. Is it just missing? Or is there a missing deactivate command? In other words, is line 7 supposed to be executed in or out of the venv. If the latter, should it not be moved up before line 3?
C. Am I correct in thinking that the setup lines (other than activate) are 1-time only, or do any have to be repeated to do further cherry-picks?
D. How does one cherry-pick multiple PRs for an issue into one backport PR? This should usually be much easier than doing multiple backports, as the backport for each dependent PR needs to wait for the previous one to be tested and merged.