Thrift fix: eta data#3674
Open
snilt wants to merge 1 commit into
Open
Conversation
|
|
Contributor
|
This PR is for pyLoad Stable, but I have to inform you that thrift is no longer supported in pyLoad Next. |
Member
@vuolter Thrift is also used by the Android app... |
Contributor
|
I think we can add it as a separate package, even I actually don't like it so much to be honest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce the issue:
Pause the server
Disable download speed limit
Add some valid package to download (preferably some large file, couple of gigabytes)
Traceback (most recent call last):
...
...
File "/home/snilt/pyload/module/lib/thrift/protocol/TBinaryProtocol.py", line 110, in writeI32
buff = pack("!i", i32)
error: 'i' format requires -2147483648 <= number <= 2147483647
It seems that the server sends some bad eta value at the very beginning of a new download.
The PR just changes the data format to integer 64-bit.
(Works fine for me since years)