optimize occurs check#4576
Closed
kozak wants to merge 125 commits intopurescript:masterpurescript/purescript:masterfrom
restaumatic:optimize-occurs-checkrestaumatic/purescript:optimize-occurs-checkCopy head branch name to clipboard
Closed
optimize occurs check#4576kozak wants to merge 125 commits intopurescript:masterpurescript/purescript:masterfrom restaumatic:optimize-occurs-checkrestaumatic/purescript:optimize-occurs-checkCopy head branch name to clipboard
kozak wants to merge 125 commits intopurescript:masterpurescript/purescript:masterfrom
restaumatic:optimize-occurs-checkrestaumatic/purescript:optimize-occurs-checkCopy head branch name to clipboard
Conversation
ES modules are already parsed in strict mode.
This reverts commit 7f0c07e.
Node.js loads JavaScript files with a .js extension as CommonJS modules unless they're within a directory with a `"type": "module"` package.json, in which case it loads them as ES modules.
Node.js ignores the package.json file of the output directory otherwise and loads .js files as CommonJS modules.
Node.js allows ES modules to import CommonJS modules by providing the module.exports object as their default export and named exports for statically discoverable properties of the module.exports object.
This has an unpleasant consequence for foreign imports: CommonJS exports named `default` are only available as the default property of their default export so a `default :: String` identifier imported from a CommonJS foreign module would actually have type `{ default :: String }`!
The require function and the exports object are not available in ES modules on Node.js.
This reverts commit 4976eee.
This reverts commit 6be0c52.
f58f5f0 'ExternsDiff: normalize type'
Fixes a bug where type synonym changes are incorrectly computed when diffing externs. See https://github.com/zyla/purs-recompilation-repro for a reproducer of the bug. Bug explanation: Externs files can have multiple entries with the same Ref, but the code in ExternsDiff assumed uniqueness. This led to buggy dependency graph construction. The fix is to merge duplicate entries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
esmin the Node.js REPL and testsesmin the Node.js REPL and tests"defaultdefault"Record