Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

Fix imports for newer mtl versions#4547

Merged
f-f merged 2 commits intopurescript:masterpurescript/purescript:masterfrom
Profpatsch:fix-mtl-importsProfpatsch/purescript:fix-mtl-importsCopy head branch name to clipboard
Jul 24, 2024
Merged

Fix imports for newer mtl versions#4547
f-f merged 2 commits intopurescript:masterpurescript/purescript:masterfrom
Profpatsch:fix-mtl-importsProfpatsch/purescript:fix-mtl-importsCopy head branch name to clipboard

Conversation

@Profpatsch
Copy link
Contributor

newer mtl does not re-export Control.Monad and Data.Monoid anymore. So we fix that by splitting the imports manually.

Description of the change

Clearly and concisely describe the purpose of the pull request. If this PR relates to an existing issue or change proposal, please link to it. Include any other background context that would help reviewers understand the motivation for this PR.


Checklist:

  • Added a file to CHANGELOG.d for this PR (see CHANGELOG.d/README.md)
  • Added myself to CONTRIBUTORS.md (if this is my first contribution)
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

newer mtl does not re-export Control.Monad and Data.Monoid anymore.
So we fix that by splitting the imports manually.
Copy link
Member

@f-f f-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is good, but CI is broken until we get #4548 in

@f-f f-f merged commit e06b9cc into purescript:master Jul 24, 2024
@kozak kozak mentioned this pull request May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.