Add support for Ubuntu artful (17.10) and bionic (18.04 to be) - #270
#270Merged
david22swan merged 1 commit intoNov 28, 2017
puppetlabs:masterpuppetlabs/puppetlabs-java:masterfrom
mhjacks:masterCopy head branch name to clipboard
Merged
Add support for Ubuntu artful (17.10) and bionic (18.04 to be)#270david22swan merged 1 commit intopuppetlabs:masterpuppetlabs/puppetlabs-java:masterfrom mhjacks:masterCopy head branch name to clipboard
david22swan merged 1 commit into
puppetlabs:masterpuppetlabs/puppetlabs-java:masterfrom
mhjacks:masterCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe it would be smarter to default 18.04 to 9 (which will definitely ship in 18.04). But this is the conservative approach.
It is a little annoying that the module fails outright on unspecified versions of the OS, but I understand the difficulties in doing otherwise.