add defensive response check in subscription fail callback#55
Closed
canthefason wants to merge 1 commit intopubnub:masterpubnub/javascript:masterfrom
Closed
add defensive response check in subscription fail callback#55canthefason wants to merge 1 commit intopubnub:masterpubnub/javascript:masterfrom
canthefason wants to merge 1 commit intopubnub:masterpubnub/javascript:masterfrom
Conversation
|
Thanks @canthefason this will be fixed in our next release! Its in our develop branch now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not very familiar with the code, but sometimes we were getting
undefinedresponses. There could be no harm with defensive checks :)