This repository was archived by the owner on Aug 15, 2022. It is now read-only.
pubnub: upgrade library and fix a pubnub issue [fixes #88010386]#2771
Merged
cihangir merged 1 commit intokoding:masterkoding/koding:masterfrom Feb 11, 2015
canthefason:pubnub-lib-upgradeCopy head branch name to clipboard
Merged
pubnub: upgrade library and fix a pubnub issue [fixes #88010386]#2771cihangir merged 1 commit intokoding:masterkoding/koding:masterfrom canthefason:pubnub-lib-upgradeCopy head branch name to clipboard
cihangir merged 1 commit intokoding:masterkoding/koding:masterfrom
canthefason:pubnub-lib-upgradeCopy head branch name to clipboard
Conversation
Contributor
|
did they accept you PR on pubnub? |
Contributor
Author
|
Nope not yet received any response. (it has just been 2 hours) But it is an obvious fix, you can see it here: pubnub/javascript#55 |
Contributor
|
👍 |
cihangir
pushed a commit
that referenced
this pull request
Feb 11, 2015
pubnub: upgrade library and fix a pubnub issue [fixes #88010386]
Contributor
|
You can use the pubnub's version when they notify you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we get 403 Forbidden error pubnub was not calling our error handler, and new PubNub version resolves this issue. Previously we were using this version, but it was trying to access an attribute of an undefined object intermittently. Now I have also fixed this issue, and also sent a PR to PubNub javascript library itself.
pubnub/javascript#55