Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

SDK-1546 evict transactional HTTP client connection pool#224

Merged
kleewho merged 6 commits intomasterpubnub/java:masterfrom
SDK-1546pubnub/java:SDK-1546Copy head branch name to clipboard
Nov 17, 2021
Merged

SDK-1546 evict transactional HTTP client connection pool#224
kleewho merged 6 commits intomasterpubnub/java:masterfrom
SDK-1546pubnub/java:SDK-1546Copy head branch name to clipboard

Conversation

@kleewho
Copy link
Contributor

@kleewho kleewho commented Nov 17, 2021

fix: Evict connections after reestablishing connection

Eviction of OkHttp connection pool after reestablishing connection (affects transactional calls)

@kleewho kleewho changed the title Sdk 1546 SDK-1546 evict transactional HTTP client connection pool Nov 17, 2021
@kleewho kleewho requested a review from parfeon as a code owner November 17, 2021 15:42
@kleewho
Copy link
Contributor Author

kleewho commented Nov 17, 2021

It was originally published as #223 and I merged it into #221 thinking that we're going to merge them both soon. We haven't so to save time of reviewers I'm publishing this once again

seba-aln
seba-aln previously approved these changes Nov 17, 2021
Copy link

@seba-aln seba-aln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

650elx
650elx previously approved these changes Nov 17, 2021
src/main/java/com/pubnub/api/managers/RetrofitManager.java Outdated Show resolved Hide resolved
.github/workflows/run_acceptance_tests.yml Show resolved Hide resolved
@kleewho kleewho dismissed stale reviews from 650elx and seba-aln via 9375c38 November 17, 2021 16:20
650elx
650elx previously approved these changes Nov 17, 2021
bartk
bartk previously approved these changes Nov 17, 2021
@kleewho
Copy link
Contributor Author

kleewho commented Nov 17, 2021

@client-engineering-bot release v5.2.3

@parfeon
Copy link
Contributor

parfeon commented Nov 17, 2021

@client-engineering-bot release as v5.2.3

@github-actions github-actions bot dismissed stale reviews from bartk and 650elx via e585b6e November 17, 2021 17:06
@kleewho kleewho merged commit dfcba9c into master Nov 17, 2021
@kleewho kleewho deleted the SDK-1546 branch November 17, 2021 18:25
@github-actions
Copy link

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.