Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

SDK-1558 Revoke Token#221

Merged
kleewho merged 18 commits intomasterpubnub/java:masterfrom
SDK-1558pubnub/java:SDK-1558Copy head branch name to clipboard
Dec 16, 2021
Merged

SDK-1558 Revoke Token#221
kleewho merged 18 commits intomasterpubnub/java:masterfrom
SDK-1558pubnub/java:SDK-1558Copy head branch name to clipboard

Conversation

@kleewho
Copy link
Contributor

@kleewho kleewho commented Nov 5, 2021

feat: Add revoke token feature

budgetpreneur
budgetpreneur previously approved these changes Nov 16, 2021
Copy link

@budgetpreneur budgetpreneur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parfeon
Copy link
Contributor

parfeon commented Nov 16, 2021

If it will be released, don't forget to add changes in first comment.

@kleewho kleewho requested a review from parfeon as a code owner November 16, 2021 11:13
@kleewho
Copy link
Contributor Author

kleewho commented Nov 16, 2021

@client-engineering-bot release

grant_permission(permissionType)
}

//DELETE http://localhost:8090/v3/pam/sub-c-067a9e98-fb50-11eb-bc10-56aa1f324334/grant/A8TlaF6egF9dE6a0DzVpnEyftEt7Nl?pnsdk=PubNub-Kotlin%2F6.2.0&requestid=6cc73a57-d282-4685-bef1-7448895b8821&uuid=pn-6ecefeb0-4625-4dc2-b2da-ffea6c784678
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kleewho some keys leaking here in comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove them

bartk
bartk previously approved these changes Dec 16, 2021
* for Gradle, add the following dependency in your `gradle.build`:
```groovy
compile group: 'com.pubnub', name: 'pubnub-gson', version: '5.2.1'
compile group: 'com.pubnub', name: 'pubnub-gson', version: '5.2.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 5.2.3 correct version number here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that important. It's going to be changed with the release.

bartk
bartk previously approved these changes Dec 16, 2021
techwritermat
techwritermat previously approved these changes Dec 16, 2021
@kleewho
Copy link
Contributor Author

kleewho commented Dec 16, 2021

@client-engineering-bot release

@github-actions github-actions bot dismissed stale reviews from techwritermat and bartk via b59e372 December 16, 2021 13:29
@kleewho kleewho merged commit d82596d into master Dec 16, 2021
@kleewho kleewho deleted the SDK-1558 branch December 16, 2021 18:13
@github-actions
Copy link

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.