fix(cluster): skip responses after IPC disconnect - #787
#787Closed
alencristen wants to merge 2 commits into
prometheus:mainprometheus/client_js:mainfrom
alencristen:fix/cluster-worker-disconnectalencristen/client_js:fix/cluster-worker-disconnectCopy head branch name to clipboard
Closed
fix(cluster): skip responses after IPC disconnect#787alencristen wants to merge 2 commits intoprometheus:mainprometheus/client_js:mainfrom alencristen:fix/cluster-worker-disconnectalencristen/client_js:fix/cluster-worker-disconnectCopy head branch name to clipboard
alencristen wants to merge 2 commits into
prometheus:mainprometheus/client_js:mainfrom
alencristen:fix/cluster-worker-disconnectalencristen/client_js:fix/cluster-worker-disconnectCopy head branch name to clipboard
Conversation
Signed-off-by: alencristen <299997878+alencristen@users.noreply.github.com>
jdmarshall
reviewed
Jul 23, 2026
| if (message.type === GET_METRICS_REQ) { | ||
| Promise.all(registries.map(r => r.getMetricsAsJSON())) | ||
| .then(metrics => { | ||
| if (!process.connected) return; |
Contributor
There was a problem hiding this comment.
Given that #778 has landed, this would be another good spot for debug output
Signed-off-by: Jason Marshall <jdmarshall@users.noreply.github.com>
jdmarshall
requested changes
Jul 27, 2026
jdmarshall
left a comment
Contributor
There was a problem hiding this comment.
As of a few PRs ago, completely silent catch blocks are no longer allowed. Please copy the debug behavior seen in other filev.
Contributor
|
This has been cherry-picked into #789 to deal with some extensive changes to this code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #563.
Stops cluster workers from calling
process.send()when metric collection finishes after their IPC channel has closed. Adds a regression test for a disconnect between request receipt and response.Checks:
npm test; focused cluster tests on Node 22, 24, and 26.