Fix commit message examples to use imperative mood #1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben
reviewed
Dec 28, 2019
Member
ben
left a comment
There was a problem hiding this comment.
😯 Wow, this was a ton of work! Thank you so much, just one small change.
Contributor
Author
|
Hmm, I just noticed that some pictures are using the old style commit messages. Examples:
This is something to think about before merging this pull-request. |
Contributor
|
I just want to say that I'm amazed by the dedication! 💚 |
Contributor
Author
|
@lazarljubenovic Thank you! 😄 |
Member
|
❤️ |
Contributor
Author
|
Thanks for merging my work! 😄 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1271
Closes #972