Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit message examples in book not using imperative mood #1271

Copy link
Copy link
@HonkingGoose

Description

@HonkingGoose
Issue body actions

Which version of the book is affected?

Problem is present in source files. So naturally all that follows from the source files is also affected.

Describe the bug:

Not all example commit messages in the source files are using the imperative mood.

Steps to reproduce:

  1. Go to https://github.com/progit/progit2/blob/master/book/03-git-branching/sections/basic-branching-and-merging.asc
    and search for: "fixed the broken email address".
  2. Commit message is not written in the imperative mood (the way git talks to you on the command line).

Expected behavior:

I think it would set a good standard if the readers get to see "proper" commit messages throughout the book. This way the readers will get familiar with the correct way to write commit messages.

Screenshots:

Additional context:

Reference to our style guide for commits:
From https://github.com/progit/progit2/blob/master/book/05-distributed-git/sections/contributing.asc
Write your commit message in the imperative: "Fix bug" and not "Fixed bug" or "Fixes bug."

I'm willing to fix the issue, by making new pull-requests, if @ben wants to change the example commit messages too.

Related issue #972.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.