Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[native] Fix build order issues with presto_server #25105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025
+15 −15
Merged

[native] Fix build order issues with presto_server #25105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions 30 presto-native-execution/presto_cpp/main/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,33 +96,33 @@ target_link_libraries(
target_link_libraries(presto_server_lib presto_thrift-cpp2 presto_thrift_extra
${THRIFT_LIBRARY})

if(PRESTO_ENABLE_REMOTE_FUNCTIONS)
add_library(presto_server_remote_function JsonSignatureParser.cpp
RemoteFunctionRegisterer.cpp)

target_link_libraries(presto_server_remote_function velox_expression
velox_functions_remote ${FOLLY_WITH_DEPENDENCIES})
target_link_libraries(presto_server_lib presto_server_remote_function)
endif()

set_property(TARGET presto_server_lib PROPERTY JOB_POOL_LINK
presto_link_job_pool)

add_executable(presto_server PrestoMain.cpp)

# Moving velox_hive_connector and velox_tpch_connector to presto_server_lib
# results in multiple link errors similar to the one below only on GCC.
# "undefined reference to `vtable for velox::connector::tpch::TpchTableHandle`"
# TODO: Fix these errors.
target_link_libraries(presto_server presto_server_lib velox_hive_connector
velox_tpch_connector)
# velox_tpch_connector is an OBJECT target in Velox and so needs to be linked
# to the executable or use TARGET_OBJECT linkage for the presto_server_lib target.
# However, we also would need to add its dependencies (tpch_gen etc).
# TODO change the target in Velox to a library target then we can move this to the
# presto_server_lib.
target_link_libraries(presto_server presto_server_lib velox_tpch_connector)

# Clang requires explicit linking with libatomic.
if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang"
AND "${CMAKE_CXX_COMPILER_VERSION}" VERSION_GREATER_EQUAL 15)
target_link_libraries(presto_server atomic)
endif()

if(PRESTO_ENABLE_REMOTE_FUNCTIONS)
add_library(presto_server_remote_function JsonSignatureParser.cpp
RemoteFunctionRegisterer.cpp)

target_link_libraries(presto_server_remote_function velox_expression
velox_functions_remote ${FOLLY_WITH_DEPENDENCIES})
target_link_libraries(presto_server_lib presto_server_remote_function)
endif()

set_property(TARGET presto_server PROPERTY JOB_POOL_LINK presto_link_job_pool)

if(PRESTO_ENABLE_TESTING)
Expand Down
Loading
Morty Proxy This is a proxified and sanitized view of the page, visit original site.