Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[native] Fix build order issues with presto_server #25105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2025

Conversation

czentgr
Copy link
Contributor

@czentgr czentgr commented May 13, 2025

There is an issue where libraries were added after the final presto_server target had already been created. That is, new libraries were added after presto_server_lib was used to build to presto_server. This means presto_server_lib might not have all expected symbols.

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

If release note is NOT required, use:

== NO RELEASE NOTE ==

@prestodb-ci prestodb-ci added the from:IBM PR from IBM label May 13, 2025
@czentgr czentgr force-pushed the cz_build_fixes branch 2 times, most recently from 79065f6 to a5b180e Compare May 14, 2025 19:17
There is an issue where libraries were added after the final
presto_server target had already been created. That is, new libraries
were added after presto_server_lib was used to build to presto_server.
This means presto_server_lib might not have all expected symbols.
@czentgr czentgr marked this pull request as ready for review May 15, 2025 19:10
@czentgr czentgr requested a review from a team as a code owner May 15, 2025 19:10
@prestodb-ci prestodb-ci requested review from a team, infvg and wanglinsong and removed request for a team May 15, 2025 19:10
@czentgr
Copy link
Contributor Author

czentgr commented May 15, 2025

@majetideepak FYI

Copy link
Collaborator

@majetideepak majetideepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @czentgr

@czentgr czentgr merged commit 1fc5687 into prestodb:master May 17, 2025
112 checks passed
@czentgr czentgr deleted the cz_build_fixes branch May 17, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.