Add rm_unneeded_f_str#642
Merged
asottile merged 1 commit intoMar 8, 2022
pre-commit:masterpre-commit/pre-commit.com:masterfrom
dannysepler:add-rm-unneeded-f-strdannysepler/pre-commit.com:add-rm-unneeded-f-strCopy head branch name to clipboard
Merged
Add rm_unneeded_f_str#642asottile merged 1 commit intopre-commit:masterpre-commit/pre-commit.com:masterfrom dannysepler:add-rm-unneeded-f-strdannysepler/pre-commit.com:add-rm-unneeded-f-strCopy head branch name to clipboard
asottile merged 1 commit into
pre-commit:masterpre-commit/pre-commit.com:masterfrom
dannysepler:add-rm-unneeded-f-strdannysepler/pre-commit.com:add-rm-unneeded-f-strCopy head branch name to clipboard
Conversation
asottile
reviewed
Mar 8, 2022
asottile
left a comment
Member
There was a problem hiding this comment.
is this needed given pyflakes (via flake8) has fstring is missing placeholders ?
| - https://github.com/shssoichiro/oxipng | ||
| - https://github.com/datarootsio/databooks | ||
| - https://github.com/standard/standard | ||
| - https://github.com/dannysepler/rm_unneeded_f_str |
Member
There was a problem hiding this comment.
- typically ids use dashes rather than underscores: https://github.com/dannysepler/rm_unneeded_f_str/blob/fb3a30dbf8a7eaad60b76bf761972af08f9d6540/.pre-commit-hooks.yaml#L1
- this is wrong: https://github.com/dannysepler/rm_unneeded_f_str/blob/fb3a30dbf8a7eaad60b76bf761972af08f9d6540/.pre-commit-hooks.yaml#L7
Member
There was a problem hiding this comment.
looks like you might also have to fix rf and fr strings -- glancing at the logic those might be broken
Contributor
Author
There was a problem hiding this comment.
good catch! fixed by dannysepler/rm_unneeded_f_str#8
Contributor
Author
|
oh, i made this package because of that flake8 error (since |
f08ee5a to
add70f7
Compare
add70f7 to
f596fa3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs here: https://github.com/dannysepler/rm_unneeded_f_str