Add pre-commit-assert-changelog to all-repos#629
Add pre-commit-assert-changelog to all-repos#629SamStudio8 wants to merge 1 commit into
Conversation
| - https://github.com/JohnnyMorganz/StyLua | ||
| - https://github.com/shssoichiro/oxipng | ||
| - https://github.com/datarootsio/databooks | ||
| - https://github.com/SamStudio8/pre-commit-assert-changelog |
There was a problem hiding this comment.
- there's no readme
- there's no license
- you've got a few security bugs waiting to happen (
shell=True,sys.path.append('.')) - executables are typically
kebab-casenotsnake_case - your project should not contain
pre-commit-as it is not affiliated with pre-commit
There was a problem hiding this comment.
Thank you for taking a look!
- README and license added
- Removed shell=True and use sys.path.append("") as per expectation for when script dir is not available
- Executable is now
assert-changelog - README clarifies this is a
pre-commithook and not apre-commitproject but I am happy to change the repo -- I just followed what seemed to be the general consensus on github
There was a problem hiding this comment.
pre-commit doesn't run with unstaged changes so I don't think this hook will work at all
There was a problem hiding this comment.
The behaviour I'm seeing is pre-commit emits a warning on unstaged changes and stashes them. The list of unstaged files is inferred by assert-changelog (https://github.com/SamStudio8/pre-commit-assert-changelog/blob/main/assert_changelog/main.py#L108). It demonstrably works for me but happy to admit this is a very alpha project that perhaps should not be in your list.
There was a problem hiding this comment.
--cached is an alias for --staged so I suspect your tool is not working
No description provided.