Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add pre-commit hooks for android-kotlin#490

Merged
asottile merged 1 commit into
pre-commit:masterpre-commit/pre-commit.com:masterfrom
jggomez:masterCopy head branch name to clipboard
Apr 20, 2021
Merged

Add pre-commit hooks for android-kotlin#490
asottile merged 1 commit into
pre-commit:masterpre-commit/pre-commit.com:masterfrom
jggomez:masterCopy head branch name to clipboard

Conversation

@jggomez

@jggomez jggomez commented Apr 14, 2021

Copy link
Copy Markdown
Contributor

Add pre-commit hooks for android-kotlin

https://github.com/jggomez/pre-commit-android-kotlin
Screen Shot 2021-04-13 at 23 15 13

@jggomez
Add pre-commit hooks for android-kotlin
cbb42a2 
Add pre-commit hooks for android-kotlin
@asottile

asottile commented Apr 14, 2021

Copy link
Copy Markdown
Member

your unittests hook can be replaced with:

language: system
entry: ./gradlew test
pass_filenames: false
always_run: true

actually, probably most of them can be adjusted to that as well? as they're written right if you stage a lot of filenames you'll get multiple invocations of each (try with --verbose)

@jggomez

jggomez commented Apr 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Ok, I have removed the script directory. Thanks

@jggomez

jggomez commented Apr 19, 2021

Copy link
Copy Markdown
Contributor Author

your unittests hook can be replaced with:

language: system
entry: ./gradlew test
pass_filenames: false
always_run: true

actually, probably most of them can be adjusted to that as well? as they're written right if you stage a lot of filenames you'll get multiple invocations of each (try with --verbose)

Hi, are there other any issues?

asottile
asottile approved these changes Apr 20, 2021
View reviewed changes

@asottile asottile left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile asottile merged commit 63fbbd6 into pre-commit:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asottile asottile asottile approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jggomez @asottile
Morty Proxy This is a proxified and sanitized view of the page, visit original site.