Keep only major.minor in Processor#version#2109
Open
MahinAnowar wants to merge 1 commit into
postcss:mainpostcss/postcss:mainfrom
MahinAnowar:version-major-minorMahinAnowar/postcss:version-major-minorCopy head branch name to clipboard
Open
Keep only major.minor in Processor#version#2109MahinAnowar wants to merge 1 commit intopostcss:mainpostcss/postcss:mainfrom MahinAnowar:version-major-minorMahinAnowar/postcss:version-major-minorCopy head branch name to clipboard
MahinAnowar wants to merge 1 commit into
postcss:mainpostcss/postcss:mainfrom
MahinAnowar:version-major-minorMahinAnowar/postcss:version-major-minorCopy head branch name to clipboard
Conversation
Member
|
We haven’t started I can keep your PR until we will start |
MahinAnowar
force-pushed
the
version-major-minor
branch
from
July 5, 2026 12:15
984730e to
504e8f1
Compare
Contributor
Author
|
Rebased onto main and resolved the conflict — kept |
MahinAnowar
force-pushed
the
version-major-minor
branch
3 times, most recently
from
July 15, 2026 17:38
7062542 to
fd22449
Compare
MahinAnowar
force-pushed
the
version-major-minor
branch
2 times, most recently
from
July 22, 2026 11:53
31a8f09 to
5a3314d
Compare
Hardcoding the full patch version forces a manual lib/processor.js edit on every patch release. Only major.minor is ever consumed (lazy-result's plugin compatibility warning), so store just that. The test/version.js guard still catches drift against package.json on minor/major bumps. Fixes postcss#2101
MahinAnowar
force-pushed
the
version-major-minor
branch
from
July 25, 2026 03:54
5a3314d to
a9251e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2101
Processor#versionnow holds onlymajor.minor('8.5'), so patch releases no longer require the manuallib/processor.jssync (the repo is currently on the 8.5.16 tag while the file said8.5.15— exactly the chore this removes).Details:
lib/lazy-result.js, already compares justsplit('.')[0]/[1], so it works unchanged with a two-segment version.test/version.jsstill guards against drift: it now comparesProcessor#versionagainstpackage.json'smajor.minor, so a minor/major bump without updatinglib/processor.jsstill fails CI, while patch releases no longer trip it.test/processor.test.ts,test/postcss.test.ts) to/^\d+\.\d+$/— they fail on the previous three-segment value and pass now — and theProcessor#versionJSDoc.All checks pass locally: 652/652 unit tests, lint, types, version guard.