Add parameter ExtractWebParts to command Add-PnPFileToProvisioningTemplate#2288
Add parameter ExtractWebParts to command Add-PnPFileToProvisioningTemplate#2288stevebeauge wants to merge 4 commits intopnp:devpnp/PnP-PowerShell:devfrom solutions-pour-sharepoint:feature/extract-webparts-with-add-pnpfiletoprovisioningtemplatesolutions-pour-sharepoint/PnP-PowerShell:feature/extract-webparts-with-add-pnpfiletoprovisioningtemplateCopy head branch name to clipboard
ExtractWebParts to command Add-PnPFileToProvisioningTemplate#2288Conversation
- parameter checking - Methods split to improve maintenability - speed improvements (StringExtensions.ReplaceCaseInsensitive) - formatting
…arts-with-add-pnpfiletoprovisioningtemplate
|
Thanks for this contribution @stevebeauge. Trying to validate your submission. Can you elaborate why the code change in Commands/Utilities/StringExtensions.cs would be necessary? You write to make it more reliable. Is there any concrete scenario where the current code fails to do what it needs to do? Otherwise I would say don't try to fix something that isn't broken. Can you elaborate on your thoughts on this? |
@KoenZomers : it's in fact a performance improvement. My comment was maybe a bit confusing. The background of this optimization came from a stackoverflow answer. |
Before creating a pull request, make sure that you have read the contribution file located at
https://github.com/SharePoint/PnP-PowerShell/blob/dev/CONTRIBUTING.md
Type
Related Issues?
What is in this Pull Request ?
This PR adds a switch parameter
ExtractWebPartto the commandAdd-PnPFileToProvisioningTemplate. When set, if the file is a classic page, its webparts are included in the target provisioning template