Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix: check rights and escape output on field forms - #1232

#1232
Merged
RomainLvr merged 2 commits into
mainpluginsGLPI/fields:mainfrom
fix_checkpluginsGLPI/fields:fix_checkCopy head branch name to clipboard
Jul 28, 2026
Merged

Fix: check rights and escape output on field forms#1232
RomainLvr merged 2 commits into
mainpluginsGLPI/fields:mainfrom
fix_checkpluginsGLPI/fields:fix_checkCopy head branch name to clipboard

Conversation

@Rom1-B

@Rom1-B Rom1-B commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • fixes #N/A
    Some ajax config endpoints only checked that the user was logged in, without verifying the config right, allowing any authenticated user to read or alter plugin field configuration.
    The default value field listing and the URL field type also echoed stored values without escaping, allowing a stored value to be rendered as active content.
    This change adds the missing right checks and escapes the affected outputs.

Screenshots (if appropriate):

@Rom1-B
Rom1-B requested a review from RomainLvr July 28, 2026 06:56
@Rom1-B
Rom1-B requested a review from jdurand-teclib July 28, 2026 07:08
@RomainLvr
RomainLvr merged commit d62aa60 into main Jul 28, 2026
3 checks passed
@RomainLvr
RomainLvr deleted the fix_check branch July 28, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.