-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Feature range slider #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature range slider #336
Changes from 1 commit
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
4c28de7
add range component
mdtusz 866d1d2
Change td to gd
mdtusz d2973f3
Update slider to have greyed exclusion zone
mdtusz eb619ef
Update slider styling to match existing ranges
mdtusz 854442d
Change arguments to makeSlider and add skeleton tests
mdtusz b0c16cd
Add slider component directory and scatter rangePlot
mdtusz 2666162
Change where range slider is inserted (now in plot_api)
mdtusz c8d87d0
Wednesday updates
mdtusz 598d69f
Linting
mdtusz 3ecdcdc
Change file name
mdtusz fb863f6
Check for null children in appendChildren helper
mdtusz 5857574
Fix handle positioning issue
mdtusz 028b46e
Use variable for slider handle width
mdtusz 4143a65
Add scattergl to allowed types
mdtusz 8cfd258
Initial pass at range slider positioning
mdtusz fe51426
Add range-sider marker size and opacity
mdtusz 09af762
Pull range-scatter plot into its own function
mdtusz f381299
Change function name from makeSlider to draw
mdtusz 149348c
Add rangeslider attribute
mdtusz 0ebc894
Position axis title correctly when rangeslider visible
mdtusz 80571f3
Fix margin values for rangeslider
mdtusz c4d19ad
Change naming from Range to RangeSlider
mdtusz 242458d
Remove initialrange attribute
mdtusz 4f4ffeb
Change Helpers to helpers and add tests
mdtusz 665c061
Move data processors to own file and fix date ranges
mdtusz c008328
Add re-ranging on slider movement
mdtusz 0a63f2a
Test slider movement
mdtusz 771546c
More tests
mdtusz 47a6829
Lock y-axis zoom/pan
mdtusz ab9ba72
Change default background color to white
mdtusz 25071ae
Fix test error and remove fdescribe
mdtusz 37e93d5
Add image baseline for range-sliders
00c0732
Minor changes to tests
mdtusz 4d238e9
Prevent slider from being drawn on export
mdtusz 21d6bdc
Merge branch 'feature-range-slider' of https://github.com/plotly/plot…
0e9bc90
Update range_slider baseline
7fd37ae
Update tests for ff
mdtusz 0b32a36
Use constant svg namespace
mdtusz 88e855b
Move supplyLayoutDefaults to own file
mdtusz df58e62
Fix borderwidth and color defaults and respective tests
mdtusz 358243d
Remove unused empty svg elements
mdtusz 6bb10c0
Remove rangeslider when visible set to false
mdtusz 0fd5c37
Fix beyond-range-end bug
mdtusz 288c4a3
Remove fdescribe
mdtusz 767a821
Fix title positioning and split out slider creation
mdtusz 67674b6
Update image baseline
2deed2e
Wrap clip path in <defs>
mdtusz 7ead461
Adjust handle grab area for more fine grained control
mdtusz 5214897
fixup! Adjust handle grab area for more fine grained control
mdtusz 771b113
Change attribute names (height->thickness, backgroundcolor->bgcolor)
mdtusz fb91908
Update image baseline
2dd5e8e
Defaults now accept `rangeslider: true` and fixrange on all counterAxes
mdtusz 83375d2
Alphabetize attributes
mdtusz cb50997
fixup! Alphabetize attributes
mdtusz 6736bbb
Fix changed height->thickness attribute
mdtusz c613c6c
Remove scattergl support (for now)
mdtusz c55bf02
Update baseline image
cbe2c26
Add role to attribute
mdtusz 271589c
Change role style->info
mdtusz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add role to attribute
- Loading branch information
commit cbe2c26dd9f91d3b5843f496507a6ee75d2211c8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be
info
.By the way, these
role
fields have no effect in plotly.js. They are used in the plotly.py when thestrip_style
option is turned on. They get stripped out incompress_attributes.js
.