Feature range slider #336
Merged
Feature range slider #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| role: 'style', | ||
| description: 'Sets the background color of the range slider.' | ||
| }, | ||
| height: { |
There was a problem hiding this comment.
let's go with thickness here.
| module.exports = { | ||
| visible: { | ||
| valType: 'boolean', | ||
| dflt: false, |
There was a problem hiding this comment.
A blank range slider ( layout.xaxis.rangeslider = {} ) should be considered visible.
| containerOut = layoutOut.xaxis.rangeslider = {}; | ||
|
|
||
| if(!containerIn.visible) return; | ||
| var containerIn = typeof layoutIn[axName].rangeslider === 'object' ? |
There was a problem hiding this comment.
use isPlainObject instead.
There was a problem hiding this comment.
ah never mind. if layoutIn[axName].rangeslider is null it won't get to that part.
| @@ -80,6 +81,7 @@ module.exports = { | ||
| 'January 1st 1970 to November 4th, 2013, set the range from 0 to 1380844800000.0' | ||
| ].join(' ') | ||
| }, | ||
| rangeslider: rangeSliderAttrs, |
|
💃 |
|
Wooo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a decent sized PR, and likely will take a while to completely review and have things changed before being ready to merge, so we may as well get started.