Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

prune global-level trace attributes that are already defined in a trace #3158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 30, 2018
Merged

prune global-level trace attributes that are already defined in a trace #3158

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
fbfe638
prune global-level trace attributes that are already defined in a trace
antoinerg Oct 25, 2018
f168ddc
fix lint
antoinerg Oct 25, 2018
7999517
properly delete nested attributes, update doc `crawl`
antoinerg Oct 25, 2018
7f60f6e
test pruning of global-level trace attributes on sankey
antoinerg Oct 26, 2018
930e4c8
do not coerce hoverlabel if it's undefined at trace level
antoinerg Oct 29, 2018
b7679a6
make sure the hoverlabel key exists but has an undefined value
antoinerg Oct 29, 2018
d501bb0
prune 'customdata' and 'ids' if undefined at trace-level attribute
antoinerg Oct 29, 2018
cd0230e
fix lint
antoinerg Oct 29, 2018
da03ceb
test that hoverlabel doesn't get coerced for parcoords
antoinerg Oct 30, 2018
397870b
prune 'transforms' attribute from traces that don't support it
antoinerg Oct 30, 2018
55881c6
do not prune `customdata` and `ids`
antoinerg Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test that hoverlabel doesn't get coerced for parcoords
  • Loading branch information
@antoinerg
antoinerg committed Oct 30, 2018
commit da03ceb4b41284f05af33a139d9424a79378d6ea
8 changes: 8 additions & 0 deletions 8 test/jasmine/tests/parcoords_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,14 @@ describe('parcoords initialization tests', function() {
expect(gd._fullData[0].tickfont).toEqual(expected);
expect(gd._fullData[0].rangefont).toEqual(expected);
});

it('should not coerce hoverlabel', function() {
var gd = Lib.extendDeep({}, mock1);

supplyAllDefaults(gd);

expect(gd._fullData[0].hoverlabel).toBeUndefined();
});
});

describe('parcoords defaults', function() {
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.