properly delete nested attributes, update doc crawl

plotly · antoinerg · Oct 30, 2018 · Oct 25, 2018 · Oct 25, 2018 · Oct 25, 2018
commit 79995174e03cda5bc1bd76a16591a3dea3de43fc
diff --git a/src/plot_api/plot_schema.js b/src/plot_api/plot_schema.js
@@ -112,6 +112,7 @@ exports.get = function() {
 *          @param {String} attrName name string
 *          @param {object[]} attrs all the attributes
 *          @param {Number} level the recursion level, 0 at the root
+ *          @param {String} fullAttrString full attribute name (ie 'marker.line')
 * @param {Number} [specifiedLevel]
 *  The level in the tree, in order to let the callback function detect descend or backtrack,
 *  typically unsupplied (implied 0), just used by the self-recursive call.
@@ -466,9 +467,9 @@ function getTraceAttributes(type) {

    // prune global-level trace attributes that are already defined in a trace
    exports.crawl(copyModuleAttributes, function(attr, attrName, attrs, level, fullAttrString) {
-        delete copyBaseAttributes[fullAttrString];
+        Lib.nestedProperty(copyBaseAttributes, fullAttrString).set(undefined);
        // Prune undefined attributes
-        if(attr === undefined) delete copyModuleAttributes[fullAttrString];
+        if(attr === undefined) Lib.nestedProperty(copyModuleAttributes, fullAttrString).set(undefined);
    });

    // base attributes (same for all trace types)