Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 41f2d8d

Browse filesBrowse files
authored
Expanding the allowable descriptions for vision system tests. (googleapis#3729)
Fixes googleapis#3681. Also updating the `nox` configuration to allow posargs pass through and be a little more Windows path friendly.
1 parent 2225289 commit 41f2d8d
Copy full SHA for 41f2d8d

3 files changed

+35-13Lines changed: 35 additions & 13 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎vision/nox.py‎

Copy file name to clipboardExpand all lines: vision/nox.py
+22-6Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,16 @@ def unit_tests(session, python_version):
3535
session.install('-e', '.')
3636

3737
# Run py.test against the unit tests.
38-
session.run('py.test', '--quiet',
39-
'--cov=google.cloud.vision', '--cov=google.cloud.vision_v1',
40-
'--cov-append', '--cov-config=.coveragerc', '--cov-report=',
41-
'tests/',
38+
session.run(
39+
'py.test',
40+
'--quiet',
41+
'--cov=google.cloud.vision',
42+
'--cov=google.cloud.vision_v1',
43+
'--cov-append',
44+
'--cov-config=.coveragerc',
45+
'--cov-report=',
46+
'tests',
47+
*session.posargs
4248
)
4349

4450

@@ -63,7 +69,12 @@ def system_tests(session, python_version):
6369
session.install('-e', '.')
6470

6571
# Run py.test against the unit tests.
66-
session.run('py.test', '--quiet', 'tests/system.py')
72+
session.run(
73+
'py.test',
74+
'--quiet',
75+
os.path.join('tests', 'system.py'),
76+
*session.posargs
77+
)
6778

6879

6980
@nox.session
@@ -84,7 +95,12 @@ def system_tests_manual_layer(session, python_version):
8495
session.install('-e', '.')
8596

8697
# Run py.test against the unit tests.
87-
session.run('py.test', '--quiet', 'tests/system_old.py')
98+
session.run(
99+
'py.test',
100+
'--quiet',
101+
os.path.join('tests', 'system_old.py'),
102+
*session.posargs
103+
)
88104

89105

90106
@nox.session
Collapse file

‎vision/setup.py‎

Copy file name to clipboardExpand all lines: vision/setup.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
readme = readme_file.read()
2626

2727
REQUIREMENTS = [
28-
'google-cloud-core >= 0.25.0, < 0.26dev',
28+
'google-cloud-core >= 0.26.0, < 0.27dev',
2929
'google-gax >= 0.15.13, < 0.16dev',
3030
'googleapis-common-protos[grpc] >= 1.5.2, < 2.0dev',
3131
]
Collapse file

‎vision/tests/system_old.py‎

Copy file name to clipboardExpand all lines: vision/tests/system_old.py
+12-6Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -332,17 +332,23 @@ def test_detect_faces_filename(self):
332332

333333

334334
class TestVisionClientLabel(BaseVisionTestCase):
335+
335336
DESCRIPTIONS = (
337+
'automobile make',
338+
'automotive design',
339+
'automotive exterior',
340+
'automotive wheel system',
336341
'car',
337-
'vehicle',
338342
'land vehicle',
339-
'automotive design',
340-
'wheel',
341-
'automobile make',
342343
'luxury vehicle',
343-
'sports car',
344+
'motor vehicle',
345+
'muscle car',
344346
'performance car',
345-
'automotive exterior',
347+
'personal luxury car',
348+
'rim',
349+
'sports car',
350+
'vehicle',
351+
'wheel',
346352
)
347353

348354
def setUp(self):

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.