Add devcontainer for contributor environment - #6904
#6904Open
kubeboiii wants to merge 2 commits into
pipe-cd:masterpipe-cd/pipecd:masterfrom
kubeboiii:feat/devcontainer-6581kubeboiii/pipecd:feat/devcontainer-6581Copy head branch name to clipboard
Open
Add devcontainer for contributor environment#6904kubeboiii wants to merge 2 commits intopipe-cd:masterpipe-cd/pipecd:masterfrom kubeboiii:feat/devcontainer-6581kubeboiii/pipecd:feat/devcontainer-6581Copy head branch name to clipboard
kubeboiii wants to merge 2 commits into
pipe-cd:masterpipe-cd/pipecd:masterfrom
kubeboiii:feat/devcontainer-6581kubeboiii/pipecd:feat/devcontainer-6581Copy head branch name to clipboard
Conversation
Fixes pipe-cd#6581 Signed-off-by: Himanshu <144804569+kubeboiii@users.noreply.github.com>
Contributor
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Contributor
|
This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable. |
Contributor
|
@mohammedfirdouss @armistcxy @khanhtc1202, PTAL when you have time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add a
.devcontainer/setup for GitHub Codespaces and VS Code Dev Containers:devcontainer.jsonon Ubuntu 24.04 with Go 1.26.2, Node 20.19.0, kubectl v1.32.2, Helm 3.8.2, and Docker-outside-of-Docker (host socket, not DinD)post-create.shinstalls arch-aware kind v0.27.0, enables Yarn via corepack, and runsmake update/go-depsandmake update/web-depsdevcontainer-lock.jsonpins devcontainer feature digests.devcontainer/README.mdwith setup, verification, optional cluster flow, and known limitationspipecdnamespace comes frommake run/pipecd, notmake up/local-cluster)Verified on VS Code Dev Containers with OrbStack (arm64): container rebuild,
docker info,go version,make build/go,docker push localhost:5001/hello-world:test.make up/local-clusterfailed in that environment (documented in.devcontainer/README.md). GitHub Codespaces andmake checkwere not run yet.Why we need it:
CONTRIBUTING.md already points contributors to Codespaces, but no dev container configuration existed. New contributors still install Go, Node, Yarn, Docker, kubectl, kind, and Helm manually. This standardizes the environment and aligns tool versions with CI where applicable.
This supersedes the stub in draft PR #6662, which only had a Dockerfile with Go 1.22 and no
devcontainer.json. Scope for v1 is devcontainer/Codespaces only; Gitpod remains deferred.Which issue(s) this PR fixes:
Fixes #6581
Does this PR introduce a user-facing change?: