Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Request PID C55D for ch55xduino hid device#592

Merged
tannewt merged 2 commits into
pidcodes:masterpidcodes/pidcodes.github.com:masterfrom
DeqingSun:patch-1DeqingSun/pidcodes.github.com:patch-1Copy head branch name to clipboard
Dec 16, 2020
Merged

Request PID C55D for ch55xduino hid device#592
tannewt merged 2 commits into
pidcodes:masterpidcodes/pidcodes.github.com:masterfrom
DeqingSun:patch-1DeqingSun/pidcodes.github.com:patch-1Copy head branch name to clipboard

Conversation

@DeqingSun

Copy link
Copy Markdown
Contributor

ch55xduino is a fork of open-sourced project sduino with LGPL license. It has been iterated for many versions.

@tannewt

tannewt commented Dec 6, 2020

Copy link
Copy Markdown
Collaborator

Please fix the CI. You'll need to add an org page too.

@DeqingSun

Copy link
Copy Markdown
Contributor Author

Please fix the CI. You'll need to add an org page too.

@tannewt This is the second PID we applied. The org page is already merged.

@tannewt

tannewt commented Dec 16, 2020

Copy link
Copy Markdown
Collaborator

Your owner name in this file must be wrong then. The CI will pass when it is correct.

@DeqingSun

Copy link
Copy Markdown
Contributor Author

Thanks. I was comparing the 2 local files between the C550 and C55D. They both have space in the org name.
And then I realized the C550 one was fixed in #554.

Now the space was removed.

@tannewt tannewt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks! I didn't realize I fixed it. :-)

@tannewt tannewt merged commit 831f21d into pidcodes:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.