Requesting PID 0D11 and 0D10 for Odiin#544
Merged
tannewt merged 4 commits intoOct 26, 2020
pidcodes:masterpidcodes/pidcodes.github.com:masterfrom
nitz:cmdwtf-odiin-pid-requestnitz/pidcodes.github.com:cmdwtf-odiin-pid-requestCopy head branch name to clipboard
Merged
Requesting PID 0D11 and 0D10 for Odiin#544tannewt merged 4 commits intopidcodes:masterpidcodes/pidcodes.github.com:masterfrom nitz:cmdwtf-odiin-pid-requestnitz/pidcodes.github.com:cmdwtf-odiin-pid-requestCopy head branch name to clipboard
tannewt merged 4 commits into
pidcodes:masterpidcodes/pidcodes.github.com:masterfrom
nitz:cmdwtf-odiin-pid-requestnitz/pidcodes.github.com:cmdwtf-odiin-pid-requestCopy head branch name to clipboard
Conversation
Collaborator
|
Please pick PIDs that don't start with 0. They are reserved: http://pid.codes/1209/ |
tannewt
requested changes
Oct 20, 2020
tannewt
left a comment
Collaborator
There was a problem hiding this comment.
Please switch to PIDs that don't start with 0 or 1.
Contributor
Author
|
Ah, my bad. I assumed because I was using all 'generic' interfaces (CDC, MSC) that the 0x0000-0x0FFF range was okay. I've moved them to 0xD10F and 0xD110. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requesting the pids 0x0D11 (Odiin Application) and 0x0D10 (Odiin Bootloader) for the Odiin device (https://github.com/nitz/Odiin)