uCANDevices#527
Merged
Merged
Conversation
tannewt
requested changes
Oct 20, 2020
tannewt
left a comment
Collaborator
There was a problem hiding this comment.
Please pick PIDs that don't start with 0. They are reserved: http://pid.codes/1209/
Contributor
Author
|
Thanks for feedback, i've move pids to 2777,2778, 2779 |
tannewt
added a commit
that referenced
this pull request
Nov 18, 2020
Restore System76 Thelio Io mapping, destroyed by #527
Collaborator
|
@Lukasz-Juranek You'll want to double check that the merge was correct for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please and 3 new PIDs (0777,0776,0775) for awesome open-source products from https://ucandevices.github.io/