Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Request PID for LNE projects#517

Merged
tannewt merged 3 commits into
pidcodes:masterpidcodes/pidcodes.github.com:masterfrom
NWIron:masterNWIron/pidcodes.github.com:masterCopy head branch name to clipboard
Oct 26, 2020
Merged

Request PID for LNE projects#517
tannewt merged 3 commits into
pidcodes:masterpidcodes/pidcodes.github.com:masterfrom
NWIron:masterNWIron/pidcodes.github.com:masterCopy head branch name to clipboard

Conversation

@NWIron

@NWIron NWIron commented May 6, 2020

Copy link
Copy Markdown
Contributor
  • Add a 'LNE' organization

  • Request PID 5858 for LNE Keyboard Device

@tannewt tannewt mentioned this pull request Sep 15, 2020
50 tasks
@tannewt

tannewt commented Sep 16, 2020

Copy link
Copy Markdown
Collaborator

Where are your hardware files?

@tannewt tannewt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing hardware files.

@NWIron

NWIron commented Oct 20, 2020

Copy link
Copy Markdown
Contributor Author

Hi, please check the following link:
https://github.com/NWIron/qmk_firmware/tree/master/keyboards/unidock

@tannewt

tannewt commented Oct 20, 2020

Copy link
Copy Markdown
Collaborator

Please provide native CAD files that are user modifiable. Images of the schematic aren't considered open source by us.

@NWIron

NWIron commented Oct 20, 2020

Copy link
Copy Markdown
Contributor Author

Please check again, I have uploaded the pcb files.

@tannewt

tannewt commented Oct 21, 2020

Copy link
Copy Markdown
Collaborator

@NWIron Please include a LICENSE file in the repo as well.

@NWIron

NWIron commented Oct 21, 2020

Copy link
Copy Markdown
Contributor Author

I moved the source codes & assets to a new repo https://github.com/NWIron/unidock.

@NWIron NWIron requested a review from tannewt October 21, 2020 06:34
Comment thread 1209/5858/index.md Outdated
owner: LNE
license: GPLv3
site: https://github.com/ln-org
source: https://github.com/NWIron/qmk_firmware

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this to the new repo.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you time, I have updated the source link!

@NWIron NWIron requested a review from tannewt October 26, 2020 01:02

@tannewt tannewt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tannewt tannewt merged commit 4b60bcc into pidcodes:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.