Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Please add Global Boot pid of 0xB007. #123

Merged
Arachnid merged 4 commits into
pidcodes:masterpidcodes/pidcodes.github.com:masterfrom
konsgn:masterkonsgn/pidcodes.github.com:masterCopy head branch name to clipboard
Dec 11, 2015
Merged

Please add Global Boot pid of 0xB007. #123
Arachnid merged 4 commits into
pidcodes:masterpidcodes/pidcodes.github.com:masterfrom
konsgn:masterkonsgn/pidcodes.github.com:masterCopy head branch name to clipboard

Conversation

@konsgn

@konsgn konsgn commented Dec 11, 2015

Copy link
Copy Markdown
Contributor

I'm trying to make a universal loader for various uC's based on the halfkay protocol. So far I have already made a functional bootloader for the PIC25K50 chips in assembly, so it fits withing the bootsector of that chip. Next attempt will be freescale or ST arm based processors.

@Arachnid

Copy link
Copy Markdown
Contributor

Thanks for your pull request! A few questions:

  • Wouldn't it be more useful to have a separate PID for each type of device, so your bootloader can distinguish them and ensure it's loading the right kind of firmware?
  • Your boot images appear to be... actual images of boots. Where is the bootloader code?
  • The 'title' properties for org and pid should display the name of the org and device as you want them shown to users on the site - so it should probably be "Global Boot", not "Global_Boot". The orgname is prefixed to the device name, so don't duplicate it in the device name.
  • 'Site' is mandatory; if you don't have one, use the same URL as for your sourcecode repository.

@konsgn

konsgn commented Dec 11, 2015

Copy link
Copy Markdown
Contributor Author

Updated!

  1. Not necessary, I'm going to identify device type based on serial number not vid/pid.
  2. Haha, Yup, just a fun startup image. I have added firmware too. The board design isn't really relevant to the goal of the project so I don't want to add that.
  3. Updated org name to Konsgn.
  4. Done!

Comment thread org/Konsgn/index.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to leave this out if you don't have a good description for your org. Other than that, looks good!

@konsgn

konsgn commented Dec 11, 2015

Copy link
Copy Markdown
Contributor Author

Merp?

Sooo remove the description underneath the title?

@Arachnid

Copy link
Copy Markdown
Contributor

Yes please, unless you have an org description that isn't about your desire for a PID. :)

@Arachnid

Copy link
Copy Markdown
Contributor

Talking about the org description here; the PID description is fine.

@konsgn

konsgn commented Dec 11, 2015

Copy link
Copy Markdown
Contributor Author

Haha, okay, done, it should be blank now.

Arachnid added a commit that referenced this pull request Dec 11, 2015
Please add Global Boot pid of 0xB007.
@Arachnid Arachnid merged commit f5aacd4 into pidcodes:master Dec 11, 2015
@konsgn

konsgn commented Dec 11, 2015

Copy link
Copy Markdown
Contributor Author

Woot! thank you. now i just gotta make sure the new firmware works.... the last time I compiled it was months ago, so at least it's quite reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.