Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

request F3FC for dRonin implementation on Lumenier Lux FC#122

Merged
Arachnid merged 2 commits into
pidcodes:masterpidcodes/pidcodes.github.com:masterfrom
d-ronin:F3FCd-ronin/pidcodes.github.com:F3FCCopy head branch name to clipboard
Dec 9, 2015
Merged

request F3FC for dRonin implementation on Lumenier Lux FC#122
Arachnid merged 2 commits into
pidcodes:masterpidcodes/pidcodes.github.com:masterfrom
d-ronin:F3FCd-ronin/pidcodes.github.com:F3FCCopy head branch name to clipboard

Conversation

@mlyle

@mlyle mlyle commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread 1209/F3FC/index.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull request! With this current title line, your entry will show up on the site as "dRonin dRonin support ...".

Can you provide a more summarised title, not including the orgname, that reflects what you'd expect to see if you plugged the device into a computer and looked at device manager or dmesg?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for running this project and the feedback! I've pushed a new attempt.

Just for background, dRonin supports a lot of flight controllers which have pre-existing USB vendor /product IDs. This is a port to a third-party controller which doesn't have a valid pair, and when running our firmware we need it to be recognizable by our ground software.

We're really thankful if your project will let us obtain a valid PID for this scenario.

Arachnid added a commit that referenced this pull request Dec 9, 2015
request F3FC for dRonin implementation on Lumenier Lux FC
@Arachnid Arachnid merged commit d13ed56 into pidcodes:master Dec 9, 2015
@hakirari

hakirari commented Dec 9, 2015

Copy link
Copy Markdown

@Arachnid lumenier lux is closed hardware, can you confirm you're now supporting requests for closed hardware ?

@Arachnid

Arachnid commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

@hakirari I assumed the hardware the PID was requested for was in the linked repo, but it appears that contains source for the firmware, and design files for different hardware.

@mlyle Can you clarify please, what hardware this PID is intended for, and what license it's available under? If it's not open-source, or you're unable to respond, I will be obliged to revoke the PID.

@mlyle

mlyle commented Dec 9, 2015

Copy link
Copy Markdown
Contributor Author

@Arachnid It is for our firmware to support outside closed hardware. The project says "open source software or hardware". I explained that in this comment: #122 (comment)

@mlyle

mlyle commented Dec 9, 2015

Copy link
Copy Markdown
Contributor Author

Note that we are a software-only project and support many other flight controllers, open and closed. Other ones have pre-existing PIDs/VIDs. This one doesn't, and for us to support it effectively it needs one while it is running our open-source firmware.

@Arachnid

Arachnid commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

I'm sorry that I missed that comment initially.

Why can't the producers of the hardware obtain a PID themselves? Alternately, why do you need a PID per device that uses your software?

@mlyle

mlyle commented Dec 9, 2015

Copy link
Copy Markdown
Contributor Author

@Arachnid We have no association with the vendor of the hardware. It ships on top of another firmware (Cleanflight, where apparently @hakirari comes from).

We can hardly use the PIDs belonging to other vendors of hardware for this device. We need a VID/PID pair so we can talk to it with USB. No VID/PID pairs belong to our project.

@Arachnid

Arachnid commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

So to clarify, the manufacturer ships with different firmware; you're obtaining this PID so users can flash your open source firmware to hardware they've purchased?

Does the PID need to be specific to this piece of hardware, or would it be useful to have a PID assigned to your code regardless of what device it's deployed on?

@mlyle

mlyle commented Dec 9, 2015

Copy link
Copy Markdown
Contributor Author

So to clarify, the manufacturer ships with different firmware; you're obtaining this PID so users can flash your open source firmware to hardware they've purchased?

Yes.

Does the PID need to be specific to this piece of hardware, or would it be useful to have a PID assigned to your code regardless of what device it's deployed on?

Ideally it'd be specific, because we have a bootloader and currently our code decides what firmware is legal to update to the target by USB VID/PID (and announces what flight boards are plugged in by USB/VID before you click "connect")

Basically, our users tend to have several flight controllers. They can buy a Lux, hold down the boot button, go into OpenOCD and flash one of our "entire firmware" images. After that, they can interact with the flight controller in our ground system, update the firmware, along with all their other ones-- usually telling them apart currently by USB device IDs.

On the other hand, we're not planning on adding many targets soon because we're drowning in maintenance. This one was a special case because it's cheap and looks nice and we think it'll make it easier for new users.

@Arachnid

Arachnid commented Dec 9, 2015

Copy link
Copy Markdown
Contributor

Fair enough, and thanks for clarifying. I've clarified the howto,
specifying that if you're producing both hardware and software, both need
to be oss; if it's just one, additional justification may be required.

The motivation here is that I really don't want to subsidise a company
producing closed source hardware and using someone else's code by offering
them a free pid; but I'm totally fine - enthusiastic, even - about groups
like yours who are using oss to make stuff work better.

Thanks for your patience, and best of luck. If you need more pids for
similar reasons in the future, please don't hesitate to file another pr.

-Nick

On Wed, 9 Dec 2015 17:43 Michael Lyle notifications@github.com wrote:

So to clarify, the manufacturer ships with different firmware; you're
obtaining this PID so users can flash your open source firmware to hardware
they've purchased?

Yes.

Does the PID need to be specific to this piece of hardware, or would it be
useful to have a PID assigned to your code regardless of what device it's
deployed on?

Ideally it'd be specific, because we have a bootloader and currently our
code decides what firmware is legal to update to the target by USB VID/PID
(and announces what flight boards are plugged in by USB/VID before you
click "connect")

Basically, our users tend to have several flight controllers. They can buy
a Lux, hold down the boot button, go into OpenOCD and flash one of our
"entire firmware" images. After that, they can interact with the flight
controller in our ground system, update the firmware, along with all their
other ones-- usually telling them apart currently by USB device IDs.

On the other hand, we're not planning on adding many targets soon because
we're drowning in maintenance. This one was a special case because it's
cheap and looks nice and we think it'll make it easier for new users.


Reply to this email directly or view it on GitHub
#122 (comment)
.

@mlyle

mlyle commented Dec 9, 2015

Copy link
Copy Markdown
Contributor Author

Thanks for taking all the time and the valuable service you're providing. :) We're excited to be able to move forward (and are amused by having the [STM32] F3 Flight Controller 0xF3FC PID).

@hakirari

hakirari commented Dec 9, 2015

Copy link
Copy Markdown

Hi,

so sorry guys I caused so much confusion. The mistake is mine, I wasn't sure about the opensource software clause. Thanks a lot for the clarification.

As @mlyle implied some vendors do decide independently what they ship their boards with, some of them are just abusing the oss and selling degenerative clones !

dronin had started supporting this board way before it was even publicly announced, imho the vendor should have the balls to osh and start shipping it with dronin !

congrats for the nice PID btw ;-)

@Arachnid

Copy link
Copy Markdown
Contributor

@hakirari No worries - this is something that definitely needed clarification, and it's cases like this that help clarify it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.