Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1e573d3

Browse filesBrowse files
authored
AttributeVersionRequirementHelper: add defaults to bool parameters (#312)
1 parent c2f9775 commit 1e573d3
Copy full SHA for 1e573d3

4 files changed

+5-5Lines changed: 5 additions & 5 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/Rules/PHPUnit/AttributeVersionRequirementHelper.php‎

Copy file name to clipboardExpand all lines: src/Rules/PHPUnit/AttributeVersionRequirementHelper.php
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ final class AttributeVersionRequirementHelper
4343

4444
public function __construct(
4545
PHPUnitVersion $PHPUnitVersion,
46-
bool $deprecationRulesInstalled,
4746
PhpVersion $phpVersion,
48-
bool $bleedingEdge,
47+
bool $deprecationRulesInstalled = false,
48+
bool $bleedingEdge = false,
4949
bool $warnAboutIncompleteVersion = true
5050
)
5151
{
Collapse file

‎tests/Rules/PHPUnit/AttributeRequiresPhpVersionRangeRuleTest.php‎

Copy file name to clipboardExpand all lines: tests/Rules/PHPUnit/AttributeRequiresPhpVersionRangeRuleTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ protected function getRule(): Rule
5252
),
5353
new AttributeVersionRequirementHelper(
5454
$phpunitVersion,
55-
false,
5655
new PhpVersion($this->phpVersion),
56+
false,
5757
true,
5858
),
5959
);
Collapse file

‎tests/Rules/PHPUnit/AttributeRequiresPhpVersionRuleTest.php‎

Copy file name to clipboardExpand all lines: tests/Rules/PHPUnit/AttributeRequiresPhpVersionRuleTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,8 @@ protected function getRule(): Rule
196196
),
197197
new AttributeVersionRequirementHelper(
198198
$phpunitVersion,
199-
$this->deprecationRulesInstalled,
200199
new PhpVersion($this->phpVersion),
200+
$this->deprecationRulesInstalled,
201201
true,
202202
$this->warnAboutIncompleteVersion,
203203
),
Collapse file

‎tests/Rules/PHPUnit/ClassAttributeRequiresPhpVersionRuleTest.php‎

Copy file name to clipboardExpand all lines: tests/Rules/PHPUnit/ClassAttributeRequiresPhpVersionRuleTest.php
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ protected function getRule(): Rule
5959
return new ClassAttributeRequiresPhpVersionRule(
6060
new AttributeVersionRequirementHelper(
6161
$phpunitVersion,
62-
false,
6362
new PhpVersion($this->phpVersion),
63+
false,
6464
true,
6565
$this->warnAboutIncompleteVersion,
6666
),

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.