Update Error Docs#14845
Open
phpstan-bot wants to merge 1 commit into
phpstan:2.2.xphpstan/phpstan:2.2.xfrom
phpstan-bot:create-pull-request/patch-yl1hd7tphpstan-bot/phpstan:create-pull-request/patch-yl1hd7tCopy head branch name to clipboard
Open
Update Error Docs#14845phpstan-bot wants to merge 1 commit intophpstan:2.2.xphpstan/phpstan:2.2.xfrom phpstan-bot:create-pull-request/patch-yl1hd7tphpstan-bot/phpstan:create-pull-request/patch-yl1hd7tCopy head branch name to clipboard
phpstan-bot wants to merge 1 commit into
phpstan:2.2.xphpstan/phpstan:2.2.xfrom
phpstan-bot:create-pull-request/patch-yl1hd7tphpstan-bot/phpstan:create-pull-request/patch-yl1hd7tCopy head branch name to clipboard
Conversation
- Rule in phpstan-phpunit now reports four distinct messages under this identifier (source locations changed from 2 to 4) - Documented "missing operator", "without operator is deprecated", "will always evaluate to false", and unsupported-constraint cases - Added fixes for each, linking phpVersion config and phpstan-deprecation-rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest
website/src/errorsIdentifiers.jsonupdate changed the source code locations for thephpunit.attributeRequiresPhpVersionidentifier from two lines to four, reflecting that theAttributeRequiresPhpVersionRulein phpstan-phpunit was expanded.I cloned
phpstan-phpunit(branch2.0.x) and read the updated rule and its test fixtures. The rule now reports four distinct error messages, all under the same identifier:'8.1') on PHPUnit 13+.phpVersion).Version constraint abc is not supported.) — an unparseable constraint string.The existing doc only covered the missing-operator case. I rewrote
website/errors/phpunit.attributeRequiresPhpVersion.mdto document all four cases with code examples and fixes, updated theshortDescription, and linked thephpVersionconfig reference and the phpstan-deprecation-rules package where relevant.No new identifiers were introduced and all 1097 identifiers remain documented.