Add additional arguments for XADD from Redis 6.2.0 missed by #1894#2393
Open
cjavad wants to merge 4 commits into
Open
Add additional arguments for XADD from Redis 6.2.0 missed by #1894#2393cjavad wants to merge 4 commits into
cjavad wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The redis
XADDcommand as specified by https://redis.io/commands/xadd/ supports additional parameters that allows for trimming in the same command as adding.It was covered in this issue #1894, and more specifically this PR #2172 addressing another issue #1961 which in turn requested the same arguments for the XTRIM command when the feature was released in redis 6.2.0.
I've been wanting to use these features in my own code, but found them lacking, and with no inherent explanation on their omission i did my best following the existing implementation of them in XTRIM.