Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

rfe-1403 : Support for export only triggers/stored procedures#892

Merged
lem9 merged 2 commits intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
Chanaka:rfe-1403Chanaka/phpmyadmin:rfe-1403Copy head branch name to clipboard
Feb 7, 2014
Merged

rfe-1403 : Support for export only triggers/stored procedures#892
lem9 merged 2 commits intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
Chanaka:rfe-1403Chanaka/phpmyadmin:rfe-1403Copy head branch name to clipboard

Conversation

@Chanaka
Copy link
Contributor

@Chanaka Chanaka commented Feb 4, 2014

Signed-off-by: Chanaka Indrajith pe.chanaka.ck@gmail.com

With this user has an option whether to export table structure while exporting server/db/table. So that this will full fill the following feature request as well.
https://sourceforge.net/p/phpmyadmin/feature-requests/1403/

Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
@lem9 lem9 self-assigned this Feb 4, 2014
@lem9
Copy link
Contributor

lem9 commented Feb 4, 2014

Chanaka,
works for me, but we'll need another option to control the export of views: the stand-in structure and the view themselves. Or maybe I forgot to untick some option. Try it with the sakila sample database.

@Chanaka
Copy link
Contributor Author

Chanaka commented Feb 5, 2014

Marc,
There is a confusion for me as well. When you try to export database, we can select what tables/views to export from the multiple select drop down. But when export server we don't have that option since drop down shows the database list. So I see there is an inconsistency. Shall we address that separately ? I can work on that ;)

@lem9
Copy link
Contributor

lem9 commented Feb 5, 2014

Chanaka,
you have a good point. By the way, just considering the database export, by default all of the tables and views are selected, but if someone lets all of them selected and unticks the new option for CREATE TABLE, I think it's expected to not get the CREATE TABLE statements. So I suggested that you add a similar option, but for the views.

@Chanaka
Copy link
Contributor Author

Chanaka commented Feb 5, 2014

Yeah, that's what I really meant. Btw, are we going with the same pull request ?

@lem9
Copy link
Contributor

lem9 commented Feb 6, 2014

If you commit to the same branch, it will be added to this pull request, which is fine by me.

Signed-off-by: Chanaka Indrajith <pe.chanaka.ck@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) when pulling 4457f40 on Chanaka:rfe-1403 into 65028af on phpmyadmin:master.

@lem9
Copy link
Contributor

lem9 commented Feb 7, 2014

Nice!

lem9 pushed a commit that referenced this pull request Feb 7, 2014
rfe-1403 : Support for export only triggers/stored procedures
@lem9 lem9 merged commit cd998a4 into phpmyadmin:master Feb 7, 2014
@Chanaka Chanaka deleted the rfe-1403 branch February 8, 2014 11:40
nijel added a commit that referenced this pull request Mar 3, 2014
Changes:

6.0.062 (2014-03-02)
	- The method startLayer() now accepts the NULL value for the $print parameter to not set the print layer option.

6.0.061 (2014-02-18)
	- Bug #893 "Parsing error on streamed xref for secured pdf" was fixed.

6.0.060 (2014-02-16)
	- Bug #891 "Error on parsing hexa fields" was fixed.
	- Bug #892 "Parsing pdf with trailing space at start" was fixed.

6.0.059 (2014-02-03)
	- SVG 'use' support was imporved.

6.0.058 (2014-01-31)
	- Bug #886 "Bugs with SVG using <defs> and <use>" was fixed.

6.0.057 (2014-01-26)
	- Bug #883 "Parsing error" was fixed.

6.0.056 (2014-01-25)
	- The automatic cache folder selection now works also with some restricted hosting environments.
	- CSS text-transform property is now supported (requires the multibyte string library for php) - see examle n. 061 (Thanks to Walter Ferraz).
	- Bug #884 "Parsing error prev tag looking for" was fixed.

Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.