fixed bug #4257 Hide fractional seconds#884
fixed bug #4257 Hide fractional seconds#884lem9 merged 7 commits intophpmyadmin:QA_4_1phpmyadmin/phpmyadmin:QA_4_1from
Conversation
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
|
Looks promising. Here is a bug I found. Testing with MySQL 5.6.15, a DATETIME(0) column. Browse the row, I see "2014-01-30 01:02:03". I click on Edit, then on the calendar icon, and the time displayed is "00:00:00". |
There was a problem hiding this comment.
Do we need changes in js/jquery/jquery-ui-timepicker-addon.js ? May create conflicts when we update jquery.
There was a problem hiding this comment.
Indeed. I was only testing the patch's behavior, I had not looked at the code in details.
There was a problem hiding this comment.
This can be ignored. What it is does is hide milliseconds and microseconds sliders when they are not supported in the datetime picker. What do you think ? Where else can I change that function ?
There was a problem hiding this comment.
I guess setting "showMicrosec" to false when calling PMA_addDatepicker should work. I'm not sure though.
There was a problem hiding this comment.
I already did that in the commit. It doesn't work
There was a problem hiding this comment.
I mean if these changes are just to hide the sliders, then they are redundant. I just checked, milli/micro sliders are hidden for me without these changes as well, just by setting "showMicrosec/milliSec" to false, which you have already done.
I'm testing for DATETIME and TIMESTAMP fields.
There was a problem hiding this comment.
Yes. Sorry, it was my mistake. I commited the changes again. I think it's working fine now
|
Apart from what Marc said, datepicker is not displayed anymore for me when editing a timestamp field. |
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
|
I'm fixing them |
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
|
Viduranga, |
|
Atul, |
|
Marc, |
|
Yes, I'm sure. Your efa453a is for grid editing, but I'm talking about clicking on Edit, then on the calendar icon (datepicker). |
|
Okay I saw it now. I was only looking at grid editing before. I will fix it soon. Thanks for pointing out |
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
|
Marc, yes I was testing grid edit TIMESTAMP, which was fixed with efa453a |
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
|
Marc and Atul, |
|
I found another bug in the current version. There is no timepicker for the 'TIME' type |
|
Thanks, I have merged your commits and fixed the merge conflict. About your other bug, you can open a bug ticket but I'm not sure that the timepicker we use works without the date part. |
|
Marc, |
Changes: 6.0.062 (2014-03-02) - The method startLayer() now accepts the NULL value for the $print parameter to not set the print layer option. 6.0.061 (2014-02-18) - Bug #893 "Parsing error on streamed xref for secured pdf" was fixed. 6.0.060 (2014-02-16) - Bug #891 "Error on parsing hexa fields" was fixed. - Bug #892 "Parsing pdf with trailing space at start" was fixed. 6.0.059 (2014-02-03) - SVG 'use' support was imporved. 6.0.058 (2014-01-31) - Bug #886 "Bugs with SVG using <defs> and <use>" was fixed. 6.0.057 (2014-01-26) - Bug #883 "Parsing error" was fixed. 6.0.056 (2014-01-25) - The automatic cache folder selection now works also with some restricted hosting environments. - CSS text-transform property is now supported (requires the multibyte string library for php) - see examle n. 061 (Thanks to Walter Ferraz). - Bug #884 "Parsing error prev tag looking for" was fixed. Signed-off-by: Michal Čihař <michal@cihar.com>
Signed-off-by: Viduranga Wijesooriya vpowerrc@gmail.com