Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix #20063 - Fix routine, event and trigger duplication when editing - #20265

#20265
Merged
MauricioFauth merged 2 commits into
phpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
predictor2718:fix/routines-duplicate-on-editpredictor2718/phpmyadmin:fix/routines-duplicate-on-editCopy head branch name to clipboard
Apr 20, 2026
Merged

Fix #20063 - Fix routine, event and trigger duplication when editing #20265
MauricioFauth merged 2 commits into
phpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
predictor2718:fix/routines-duplicate-on-editpredictor2718/phpmyadmin:fix/routines-duplicate-on-editCopy head branch name to clipboard

Conversation

@predictor2718

Copy link
Copy Markdown
Contributor

Summary

  • Modal event listeners (shown.bs.modal, hidden.bs.modal) accumulated on each editorDialog() call, causing duplicate rows after repeated edits
  • Added { once: true } to all affected listeners in routines, events, and triggers
  • Same fix applied to editor, export, and execute modals

Fixes #20063

…times

Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
… multiple times

Signed-off-by: Nicolai Ehrhardt <245527909+predictor2718@users.noreply.github.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@williamdes williamdes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@MauricioFauth MauricioFauth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MauricioFauth
MauricioFauth merged commit ea951ef into phpmyadmin:master Apr 20, 2026
45 checks passed
@MauricioFauth MauricioFauth self-assigned this Apr 20, 2026
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[6.0]: Routines are duplicated when edited a few times

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.