Please fix the testsuite so that it does not fail with your changes.

Hi Michal,
I have updated the test cases, according to the modifications that I have done

a few general remarks:

• our coding style defines not to use lines longer than 85 characters. You can use phpcs (PHP Code Sniffer, see http://wiki.phpmyadmin.net/pma/Jenkins_Setup to install) to check violations against the codingstyle we use
• when concatenating with . leave a space before and after the dot. This makes the code more readable
• watch out for space characters on empty lines and trailing spaces

Coding style looks good, thanks!

Tested and it seems to work.
I noticed that some sections where removed from the css files, (fe. common.css.php lines 1284-1302, 1308-1362, fe. li_mysql_collations) but no code was added to insert this icon in the appropriate place.

Can someone else confirm that the right icons are already in the code? @roccivic, @lem9, @nijel?

Dieter,
do you mean li_select_mysql_collation ? I see that some code has been inserted by hisamith in index.php to call
PMA_Util::getImage('s_asci.png').

No, for the removed lines in common.css.php 1654-1680, you see a replacement in index.php, but the lines in common.css.php I mentioned in the previous comment, I don't see a replacement in other code. That's why I was wondering if there should be a replacement in the code, or maybe it is already there and the icon's in the css are obsolete already.
Looking for those items in the code (I tried 'grep -r li_select_mysql_collation *') doesn't turn up a match, so that's why I'm wondering if they are still needed.

Dieter,
let's take an example. You mention lines 1284-1302 (I believe you refer to bc47ff4). On line 1285, we see he removed the reference to b_newdb.png. However, in c88420a we see that he added a reference to this icon in libraries/display_create_database.lib.php.

The lines 1284-1302 are OK, the icons were removed from the css and inserted to the appropriate places in the code. I referenced the wrong range (1284-1302) in a previous comment, my bad.

I mean the lines 1308-1362 (1678-1732 in the pmahomme version) : 'li_mysql_variables' to 'li_user_preferences'
A quick look for some of the icons (*.png) in the current code base, turns up they are used, so I guess their occurence in the css files is obsolete and they can be removed.
But because I didn't see any replacement in hisamith's patch, I was wondering if they were forgotten, or were obsolete and could be removed.

Yes, they must be obsolete.

We have a winner for Contest 6, congratulations.

Thank you.