Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Contest-6] No hard-coded icons in css#196

Closed
hisamith wants to merge 1 commit intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
hisamith:css_changehisamith/phpmyadmin:css_changeCopy head branch name to clipboard
Closed

[Contest-6] No hard-coded icons in css#196
hisamith wants to merge 1 commit intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
hisamith:css_changehisamith/phpmyadmin:css_changeCopy head branch name to clipboard

Conversation

@hisamith
Copy link
Contributor

@hisamith hisamith commented Mar 2, 2013

Modified "list-style-type" to "none" for the list items that has an image as the bullet point and aligned them.

Modified "list-style-type" to "none" for the list items that has an image as the bullet point and aligned them
@lem9
Copy link
Contributor

lem9 commented Mar 3, 2013

Updated title of pull request, this is for item #6 of the contest.

@roccivic
Copy link
Contributor

roccivic commented Mar 4, 2013

Hi Samith,

you are definitely going in the right direction. However, IMO it's not even half done.

If you search the common.css.php file for ".png", there are a whole bunch more occurrences of hard-coded images. For the successful completion of this feature request, all of the hard-coded images that are also available as a CSS sprite must be replaced by their sprite counterparts.

Also, there seems to be very little point to commenting out CSS code, just delete the whole expression.

And finally, you must also update the CSS file in the "original" theme.

Bye,
Rouslan

@roccivic roccivic closed this Mar 4, 2013
@hisamith
Copy link
Contributor Author

hisamith commented Mar 5, 2013

Hi Rouslan,

Thanks for your advices and guide lines. I have improved my code replacing all of the hard-coded images that are also available as a CSS sprite, by their sprite counterparts as you suggested (#200). If there are any drawbacks or required improvements let me know.

Bye,
Samith

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.