[Contest-6] No hard-coded icons in css#196
[Contest-6] No hard-coded icons in css#196hisamith wants to merge 1 commit intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom
Conversation
Modified "list-style-type" to "none" for the list items that has an image as the bullet point and aligned them
|
Updated title of pull request, this is for item #6 of the contest. |
|
Hi Samith, you are definitely going in the right direction. However, IMO it's not even half done. If you search the Also, there seems to be very little point to commenting out CSS code, just delete the whole expression. And finally, you must also update the CSS file in the "original" theme. Bye, |
|
Hi Rouslan, Thanks for your advices and guide lines. I have improved my code replacing all of the hard-coded images that are also available as a CSS sprite, by their sprite counterparts as you suggested (#200). If there are any drawbacks or required improvements let me know. Bye, |
Modified "list-style-type" to "none" for the list items that has an image as the bullet point and aligned them.