Add support for theme color modes - #18257
#18257Add support for theme color modes#18257MauricioFauth merged 3 commits intophpmyadmin:masterphpmyadmin/phpmyadmin:masterfrom MauricioFauth:theme-color-modesMauricioFauth/phpmyadmin:theme-color-modesCopy head branch name to clipboard
Conversation
3e512c8 to
7572ab9
Compare
| "url": "https://www.phpmyadmin.net/", | ||
| "supports": ["6.0"] | ||
| "supports": ["6.0"], | ||
| "colorModes": ["light", "dark"] |
There was a problem hiding this comment.
Could we say they can be translated ?
Or maybe just for themes we provide ?
There was a problem hiding this comment.
That's a great thought and good question.
I suspect we shouldn't translate the modes; that can get really messy with multiple languages especially with a theme like Metro (would you translate "Redmond?"). Seems to me it's easier and less messy to not translate these values at all, but I'm not certain of that.
There was a problem hiding this comment.
would you translate "Redmond?"
Nope
Seems to me it's easier and less messy to not translate these values at all, but I'm not certain of that.
Well, I think people will come at us and ask for translations of light and dark.
But less probably Redmond or other stuff that's not really an English word from a non english user
That's a bit complicated to decide
There was a problem hiding this comment.
I added translations for Light and Dark, which I think will be the more common ones. Other colors names will not have translations.
f4ec87a to
4bab619
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #18257 +/- ##
============================================
- Coverage 54.17% 54.15% -0.02%
- Complexity 16406 16417 +11
============================================
Files 628 627 -1
Lines 67620 67649 +29
============================================
+ Hits 36631 36636 +5
- Misses 30989 31013 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
4bab619 to
30b4d2e
Compare
Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
Uh oh!
There was an error while loading. Please reload this page.