[ticket/17590] Use index.php as frontend controller #6916
Open
rubencm wants to merge 1 commit intophpbb:masterphpbb/phpbb:masterfrom
Open
[ticket/17590] Use index.php as frontend controller #6916rubencm wants to merge 1 commit intophpbb:masterphpbb/phpbb:masterfrom
rubencm wants to merge 1 commit intophpbb:masterphpbb/phpbb:masterfrom
Conversation
4 tasks
5141fb5 to
5e5e370
Compare
There was a problem hiding this comment.
Pull request overview
This pull request implements a change to use index.php as the frontend controller instead of app.php throughout the phpBB codebase. This is a significant refactoring that affects routing, installation, configuration files, and tests.
Changes:
- Renamed frontend controller from
app.phptoindex.phpacross all routing and path handling code - Updated web server configuration files (.htaccess, web.config, nginx, lighttpd) to route through index.php
- Added backward compatibility redirect in app.php to redirect to index.php with 301 status
- Updated installer to use index.php as entry point, removing the HTML redirect file
- Updated all test cases to use index.php instead of app.php
Reviewed changes
Copilot reviewed 47 out of 48 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| phpBB/app.php | Added 301 redirect for backward compatibility from app.php to index.php |
| phpBB/.htaccess | Updated rewrite rules to use index.php instead of app.php |
| phpBB/web.config | Updated IIS rewrite rules to use index.php |
| phpBB/phpbb/routing/router.php | Updated regex to strip index.php from pathinfo |
| phpBB/phpbb/routing/helper.php | Updated route generation to use index.php, modified admin path handling logic |
| phpBB/phpbb/path_helper.php | Updated path manipulation logic to handle index.php, replaced string functions with modern alternatives |
| phpBB/phpbb/members/controller/online.php | Updated session page parsing to strip index.php |
| phpBB/phpbb/install/module/obtain_data/task/obtain_server_data.php | Updated comment to reference index.php |
| phpBB/phpbb/feed/helper.php | Updated attachment URL pattern to match index.php |
| phpBB/install/index.php | New installer entry point file (replaces index.html redirect) |
| phpBB/install/index.html | Removed HTML redirect file |
| phpBB/install/startup.php | Updated comment to reference index.php |
| phpBB/includes/functions.php | Updated install redirect to point to install/index.php |
| phpBB/includes/acp/acp_update.php | Updated update links to use install/index.php |
| phpBB/includes/acp/acp_board.php | Updated comments about mod_rewrite to reference index.php |
| phpBB/language/en/acp/board.php | Updated language string explaining mod_rewrite behavior |
| phpBB/docs/*.conf | Updated all sample server configuration files |
| phpBB/docs/INSTALL.html | Updated installation documentation to reference index.php |
| phpBB/config/default/routing/routing.yml | Updated routing configuration comment |
| phpBB/assets/javascript/installer.js | Updated installer JavaScript to look for index.php |
| vagrant/after.sh | Updated comment in setup script |
| tests/**/* | Updated all test files to use index.php instead of app.php (29 test files) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
marc1706
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17590