[ticket/17588] Move index page to controller#6903
Merged
marc1706 merged 3 commits intophpbb:masterphpbb/phpbb:masterfrom Jan 20, 2026
Merged
[ticket/17588] Move index page to controller#6903marc1706 merged 3 commits intophpbb:masterphpbb/phpbb:masterfrom
marc1706 merged 3 commits intophpbb:masterphpbb/phpbb:masterfrom
Conversation
e8771b2 to
7dc4599
Compare
7dc4599 to
11882c9
Compare
c786b6f to
bbc2fcb
Compare
a35ac0b to
29e78d6
Compare
GanstaZ
reviewed
Jan 2, 2026
GanstaZ
reviewed
Jan 2, 2026
c13da46 to
f032db2
Compare
There was a problem hiding this comment.
Pull request overview
This pull request refactors the index page functionality by moving it from a procedural script to a proper controller-based implementation, aligning with the modern architecture used for other phpBB pages.
Key Changes:
- Created a new
phpbb\forum\controller\indexcontroller to handle index page display logic - Extracted birthday functionality into a dedicated
phpbb\forum\birthday_helperservice - Updated all hardcoded references to
index.$phpExthroughout the codebase to use the new controller route
Reviewed changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| phpBB/index.php | Simplified to delegate request handling to the Symfony HTTP kernel |
| phpBB/phpbb/forum/controller/index.php | New controller implementing index page display logic |
| phpBB/phpbb/forum/birthday_helper.php | New helper service for birthday functionality extracted from index.php |
| phpBB/config/default/routing/routing.yml | Added route definition for the index controller |
| phpBB/config/default/container/services_forum.yml | New service configuration file for forum-related services |
| phpBB/config/default/container/services.yml | Imports the new services_forum.yml configuration |
| phpBB/config/default/container/services_ucp.yml | Updated delete_cookies service to include controller.helper dependency |
| phpBB/config/default/container/services_mention.yml | Updated mention controller service to include controller.helper dependency |
| phpBB/config/default/container/services_content.yml | Updated message form services to include controller.helper dependency |
| phpBB/phpbb/members/viewonline_helper.php | Added handling for phpbb_index_controller route |
| phpBB/phpbb/ucp/controller/delete_cookies.php | Updated to use controller helper for index route generation |
| phpBB/phpbb/ucp/controller/reset_password.php | Updated to use controller helper for index route generation |
| phpBB/phpbb/mention/controller/mention.php | Added controller.helper dependency and updated redirect logic |
| phpBB/phpbb/message/form.php | Added controller.helper dependency for route generation |
| phpBB/phpbb/message/admin_form.php | Updated constructor to pass controller.helper to parent |
| phpBB/phpbb/notification/type/base.php | Minor formatting improvement (blank line) |
| phpBB/includes/functions.php | Updated U_INDEX template variable to use controller route |
| phpBB/includes/ucp/*.php | Updated all index redirects to use controller route |
| phpBB/ucp.php | Centralized controller.helper instantiation and updated all index redirects |
| phpBB/mcp.php | Updated bot redirect to use controller route |
| phpBB/search.php | Updated mark forums link to use controller route |
| phpBB/posting.php | Centralized controller.helper instantiation and updated redirects |
| phpBB/app.php | Removed extraneous empty comment block |
| tests/viewonline/helper_test.php | Reorganized test data to group index route tests with route-based pages |
| tests/functional/acp_smilies_test.php | Test marked as skipped |
| tests/functional/acp_attachments_test.php | Changed self::$client->request to self::request for consistency |
| tests/test_framework/phpbb_functional_test_case.php | Simplified mock creation by removing unnecessary constructor arguments |
| tests/mention/controller_test.php | Added controller.helper mock dependency |
| tests/text_formatter/s9e/mention_helper_test.php | Simplified mock creation |
| tests/console/user/base.php | Simplified mock creation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1cafc37 to
4bbe73d
Compare
GanstaZ
reviewed
Jan 2, 2026
0d20091 to
549f255
Compare
marc1706
reviewed
Jan 5, 2026
PHPBB-17588
PHPBB-17588
PHPBB-17588
marc1706
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Tracker ticket:
https://tracker.phpbb.com/browse/PHPBB-17588