Feature: Add Postgres SSLMODE connection option#283
Merged
corpsee merged 14 commits intoFeb 24, 2019
php-censor:masterphp-censor/php-censor:masterfrom
mikebronner:masterCopy head branch name to clipboard
Merged
Feature: Add Postgres SSLMODE connection option#283corpsee merged 14 commits intophp-censor:masterphp-censor/php-censor:masterfrom mikebronner:masterCopy head branch name to clipboard
corpsee merged 14 commits into
php-censor:masterphp-censor/php-censor:masterfrom
mikebronner:masterCopy head branch name to clipboard
Conversation
Member
|
Issue #282. @mikebronner It isn't clear... Do you want to use SSL connection with main PHP Censor DB or with Postgres plugin? It isn't same. |
Contributor
Author
|
@corpsee Sorry, and I was looking in the wrong place. I am trying to use it with the main php-censor database. |
mikebronner
commented
Feb 21, 2019
Contributor
Author
|
@corpsee Would you mind taking a look at this PR? I have it in a functional state at this point. Any feedback welcome. Thanks! :) |
corpsee
reviewed
Feb 23, 2019
Member
|
@mikebronner Also could you add infotmation about new option to application config documentation? |
corpsee
reviewed
Feb 23, 2019
corpsee
reviewed
Feb 23, 2019
Member
|
@mikebronner Thank you for the great work! 👍 |
Contributor
Author
|
@corpsee Thanks for the feedback. I believe I have made all requested changes. Let me know if I missed anything. :) |
Member
|
@mikebronner Good. Thanks! |
Member
|
PR merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
The goal of this PR is to allow for a Postgres connection over SSL for the main php-censor database.
Next Steps
sslmodeto regular database connection.Challenges
sslmode=requirein its connection string.Fixes #282