Feature: Phan Plugin#171
Merged
corpsee merged 3 commits intoApr 25, 2018
php-censor:masterphp-censor/php-censor:masterfrom
caouecs:plugin_phanCopy head branch name to clipboard
Merged
Feature: Phan Plugin#171corpsee merged 3 commits intophp-censor:masterphp-censor/php-censor:masterfrom caouecs:plugin_phanCopy head branch name to clipboard
corpsee merged 3 commits into
php-censor:masterphp-censor/php-censor:masterfrom
caouecs:plugin_phanCopy head branch name to clipboard
Conversation
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function __construct(Builder $builder, Build $build, array $options = []) |
Member
There was a problem hiding this comment.
Class PHPCensor\Plugin\Phan::__construct is missing a docblock.
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function __construct(Builder $builder, Build $build, array $options = []) |
Member
There was a problem hiding this comment.
Class PHPCensor\Plugin\Phan::__construct is missing a docblock.
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function __construct(Builder $builder, Build $build, array $options = []) |
Member
There was a problem hiding this comment.
Class PHPCensor\Plugin\Phan::__construct is missing a docblock.
| * | ||
| * @throws \Exception | ||
| */ | ||
| protected function processReport($jsonString) |
Member
There was a problem hiding this comment.
Class PHPCensor\Plugin\Phan::processReport is missing a docblock.
corpsee
reviewed
Apr 24, 2018
| 'phan', | ||
| $data['check_name']."\n\n".$data['description'], | ||
| $this->severity($data['severity']), | ||
| $data['location']['path'] ?? '??', |
Member
|
@caouecs Excellent work! Can you fix code to support PHP 5.6 please? |
Contributor
Author
|
Done |
Member
|
@caouecs Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution type
New plugin
Description of change
I did a plugin for Phan, it launches a command to find PHP files, and after it launches Phan on this list.