PHPDocBlockChecker Plugin Detailed Error Logging#159
Merged
corpsee merged 2 commits intoFeb 27, 2018
php-censor:masterphp-censor/php-censor:masterfrom
Dave13h:Plugin-DocBlockChecker-detailed-errorsDave13h/php-censor:Plugin-DocBlockChecker-detailed-errorsCopy head branch name to clipboard
Merged
PHPDocBlockChecker Plugin Detailed Error Logging#159corpsee merged 2 commits intophp-censor:masterphp-censor/php-censor:masterfrom Dave13h:Plugin-DocBlockChecker-detailed-errorsDave13h/php-censor:Plugin-DocBlockChecker-detailed-errorsCopy head branch name to clipboard
corpsee merged 2 commits into
php-censor:masterphp-censor/php-censor:masterfrom
Dave13h:Plugin-DocBlockChecker-detailed-errorsDave13h/php-censor:Plugin-DocBlockChecker-detailed-errorsCopy head branch name to clipboard
Conversation
This PR logs the error from the PHPDocBlockChecker rather than just logging that the doc block is missing.
| @@ -154,12 +154,43 @@ public function execute() | ||
| protected function reportErrors($output) |
Member
There was a problem hiding this comment.
Class PHPCensor\Plugin\PhpDocblockChecker::reportErrors is missing a docblock.
Member
|
@Dave13h Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR logs the error from the PHPDocBlockChecker rather than just logging that the doc block is missing.
Contribution type
Feature
Description of change
Previously when the docblock checker failed, it would just log that the docblock was missing rather than the actual message coming back from the plugin.