Technical Debt Plugin 'Allowed Errors' config ignored#158
Closed
gmce93 wants to merge 1 commit into
php-censor:masterphp-censor/php-censor:masterfrom
gmce93:technical-debt-warningsgmce93/php-censor:technical-debt-warningsCopy head branch name to clipboard
Closed
Technical Debt Plugin 'Allowed Errors' config ignored#158gmce93 wants to merge 1 commit intophp-censor:masterphp-censor/php-censor:masterfrom gmce93:technical-debt-warningsgmce93/php-censor:technical-debt-warningsCopy head branch name to clipboard
gmce93 wants to merge 1 commit into
php-censor:masterphp-censor/php-censor:masterfrom
gmce93:technical-debt-warningsgmce93/php-censor:technical-debt-warningsCopy head branch name to clipboard
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
============================================
- Coverage 22.44% 22.44% -0.01%
- Complexity 2781 2783 +2
============================================
Files 154 154
Lines 8882 8884 +2
============================================
Hits 1994 1994
- Misses 6888 6890 +2
Continue to review full report at Codecov.
|
Member
|
@glennmcewan Good work! Can you rebase your branch to the fresh |
Member
|
Merge manually. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution type
Bug fix.
Description of change
Sets the
allowed_errorsplugin property correctly, from the given config options.At the moment, the
allowed_errorsconfig value is set in to a$allowed_errorsclass property, which is incorrect as the Technical Debt Plugin references the$allowedErrorsclass property to determine the success of the plugin's execution.It's perhaps worth considering:
allowed_errorstoallowed_warnings, like every other plugin.allowed_warningsbetween all plugins. Should make them a bit more DRY.