Correct issue #153: phpcs ignores 'path' setting#155
Merged
corpsee merged 1 commit intoFeb 22, 2018
php-censor:masterphp-censor/php-censor:masterfrom
AlexisFinn:patch-1Copy head branch name to clipboard
Merged
Correct issue #153: phpcs ignores 'path' setting#155corpsee merged 1 commit intophp-censor:masterphp-censor/php-censor:masterfrom AlexisFinn:patch-1Copy head branch name to clipboard
corpsee merged 1 commit into
php-censor:masterphp-censor/php-censor:masterfrom
AlexisFinn:patch-1Copy head branch name to clipboard
Conversation
The 'path' value was not being set in the class constructor.
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
============================================
- Coverage 16.03% 16.03% -0.01%
- Complexity 3002 3003 +1
============================================
Files 196 196
Lines 12413 12415 +2
============================================
Hits 1991 1991
- Misses 10422 10424 +2
Continue to review full report at Codecov.
|
Member
|
@AlexisFinn Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'path' value was not being set in the class constructor.
Contribution type
Bug fix
Description of change
Set the option in the phpcs plugin class constructor, and correct a small indentation inconsistency while at it